GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2335

    [ZEPPELIN-2426] Improve graph setting DOMs

    ### What is this PR for?
    
    Improve graph setting DOMs. Refer the attached screenshots.
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    
    * [x] - columnselector setting
    * [x] - pivot setting
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2426](https://issues.apache.org/jira/browse/ZEPPELIN-2426)
    
    ### How should this be tested?
    
    1. Display a table.
    2. Click charts including scatter chart. (written with columnselector 
transformation)
    
    ### Screenshots (if appropriate)
    
    #### Before: Pivot
    
    
![image](https://cloud.githubusercontent.com/assets/4968473/25922442/34abce1e-3614-11e7-96d6-614b16d832d8.png)
    
    #### After: Pivot
    
    
![image](https://cloud.githubusercontent.com/assets/4968473/25922438/2f2243d8-3614-11e7-9ca8-cce61d338371.png)
    
    #### Before: Columnselector
    
    
![image](https://cloud.githubusercontent.com/assets/4968473/25922404/1607ccba-3614-11e7-9aa5-5861f7cdecd8.png)
    
    #### After: Columnselector
    
    
![image](https://cloud.githubusercontent.com/assets/4968473/25922411/1c1029c2-3614-11e7-9006-f9ebc1f43d08.png)
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-2426/improve-graph-setting=dom

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2335.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2335
    
----
commit d70b379226fe08f1e3c60d0aa52167c79105e8de
Author: 1ambda <[email protected]>
Date:   2017-05-10T04:51:50Z

    fix: Remove invalid ng-if

commit 1b7c1245c439e9f73705365a1533008193db5cbb
Author: 1ambda <[email protected]>
Date:   2017-05-10T21:32:50Z

    feat: Prettify columnselector setting

commit 48b72b757e3acb5f198f382183741a3bfff561cd
Author: 1ambda <[email protected]>
Date:   2017-05-10T21:32:58Z

    feat: Prettify pivot setting

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to