GitHub user soralee opened a pull request:

    https://github.com/apache/zeppelin/pull/2339

    [ZEPPELIN-2430] The xAxis text in the line and area chart overlaps

    ### What is this PR for?
    Like in the #2133 case, the xAxis text of area chart and line chart is 
overlapping.
    For reusing form, I created a html template file for how to show xLabel 
and, in `rotate` button checked, show up `input` box for set value of rotate 
degree.
    
    ### What type of PR is it?
    [Bug Fix | Improvement]
    
    ### What is the Jira issue?
    * [ZEPPELIN-2430 - The xlabel text in the line and area graph 
overlaps](https://issues.apache.org/jira/browse/ZEPPELIN-2430)
    
    ### How should this be tested?
    1. Click `settings` button in the barChart 
    2. Check to whether there are `default`, `rotate`, `hide` button or not.
    3. Test to click each button and whether it works well or not for each 
situation.
    4. In rotate button checked, check to set value and showing xAixs rotate 
degree properly.
    5. In the areaChart and lineChart, test with above steps.
    
    ### Screenshots (if appropriate)
    [Before]
    
![image](https://cloud.githubusercontent.com/assets/8110458/25982243/cffe5510-3715-11e7-8ca9-5c9f1147b61f.png)
    
    
![image](https://cloud.githubusercontent.com/assets/8110458/25982234/bef46cc8-3715-11e7-9839-ee10ebba3423.png)
    
    [After]
    
![z_overlap_in_text](https://cloud.githubusercontent.com/assets/8110458/25982228/a9659aa8-3715-11e7-938c-8602f5b9b270.gif)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/soralee/zeppelin 
ZEPPELIN-2430_overlap_line_area

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2339.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2339
    
----
commit 59fa755522953e7a03a0164cdb150b7171adce37
Author: soralee <sora0...@zepl.com>
Date:   2017-05-08T08:16:15Z

    fix area chart

commit 3f500e37da3f5160493c86f893b1e0725876e49c
Author: soralee <sora0...@zepl.com>
Date:   2017-05-12T03:25:08Z

    create template and apply area and line chart

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to