GitHub user 1ambda reopened a pull request:
https://github.com/apache/zeppelin/pull/2327
[ZEPPELIN-2520] DON'T set bottom margin for markdown table
### What is this PR for?
DON'T set bottom margin for the markdown table.
#### Implementation Details
that's because `.paragraph table` overwrites `.markdown-body table`
### What type of PR is it?
[Bug Fix]
### Todos
* [x] - Bump version up from 2.4.0 to 2.6.0
* [x] - Update `bin_license/LICENSE`
* [x] - Import it using commonjs
* [x] - Fix paragraph.css
### What is the Jira issue?
[ZEPPELIN-2520](https://issues.apache.org/jira/browse/ZEPPELIN-2520)
### How should this be tested?
1. Build: `mvn clean package -DskipTests;`
2. Execute a paragraph using this text.
```md
Colons can be used to align columns.
| Tables | Are | Cool |
| ------------- |:-------------:| -----:|
| col 3 is | right-aligned | $1600 |
| col 2 is | centered | $12 |
| zebra stripes | are neat | $1 |
There must be at least 3 dashes separating each header cell.
The outer pipes (|) are optional, and you don't need to make the
raw Markdown line up prettily. You can also use inline Markdown.
Markdown | Less | Pretty
--- | --- | ---
*Still* | `renders` | **nicely**
1 | 2 | 3
```
### Screenshots (if appropriate)
#### Before
#### After
### Questions:
* Does the licenses files need update?
* Is there breaking changes for older versions?
* Does this needs documentation?
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin
ZEPPELIN-2520/bottom-margin-for-md-table
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2327.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2327
----
commit 03bf9a3af684e07fed3ce1ced1a2227bd8e9871c
Author: 1ambda <[email protected]>
Date: 2017-05-09T21:40:26Z
fix: Use github-markdown-css 2.6.0 from npm
commit 49ea902a05d6f7ac3ee2e5df44faf2c783bd4c5e
Author: 1ambda <[email protected]>
Date: 2017-05-09T21:40:42Z
fix: DON'T set bottom-margin for markdown table
commit 2c54b667b5a0beb48012684caf675486a722b848
Author: 1ambda <[email protected]>
Date: 2017-05-10T01:47:15Z
fix: use css loader for test
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
