[GitHub] zeppelin pull request #2357: [ZEPPELIN-2429] Improve `import notebook` dialo...

Sun, 21 May 2017 00:28:53 -0700 

GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2357

    [ZEPPELIN-2429] Improve `import notebook` dialog style

    ### What is this PR for?
    
    Improve `import notebook` dialog style. See the attached screenshots.
    
    ### What type of PR is it?
    [Improvement]
    
    ### Todos
    
    DONE
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2429](https://issues.apache.org/jira/browse/ZEPPELIN-2429)
    
    ### How should this be tested?
    
    1. Build: `mvn clean package -DskipTests; ./bin/zeppelin-daemon.sh restart`
    2. Run Zeppelin and open browser: `localhost:8080`
    3. `import notebook` functionality should work as like before.
    
    ### Screenshots (if appropriate)
    
    #### Before
    
    
![image](https://cloud.githubusercontent.com/assets/4968473/26281995/816eed22-3e42-11e7-8ec5-8bca9f54f919.png)
    
    
    #### After
    
    
![image](https://cloud.githubusercontent.com/assets/4968473/26281990/6f8df684-3e42-11e7-8fe5-df6f964e5921.png)
    
    
![image](https://cloud.githubusercontent.com/assets/4968473/26281992/74732f52-3e42-11e7-8d40-5083e63c7714.png)
    
    
    ### Questions:
    * Does the licenses files need update?
    * Is there breaking changes for older versions?
    * Does this needs documentation?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin improve-import-dialog

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2357.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2357
    
----
commit c46516b2f17dccbd9a4c48c6d675d9ad1d78c4d0
Author: 1ambda <[email protected]>
Date:   2017-05-21T02:44:24Z

    feat: Use note-import-dialog.css

commit 85ecc1062b943e33ceed3eef29488eeada9e34a3
Author: 1ambda <[email protected]>
Date:   2017-05-21T02:46:07Z

    style: Reformat note import dialog html

commit 2c868c73c6f5c40201a8c85ce9cc6219a656c35e
Author: 1ambda <[email protected]>
Date:   2017-05-21T02:47:53Z

    feat: Style note import dialog header

commit df702c460724e931ea2682724aece127c10f6514
Author: 1ambda <[email protected]>
Date:   2017-05-21T07:16:51Z

    feat: Style import dialog body

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to