GitHub user prabhjyotsingh opened a pull request:

    https://github.com/apache/zeppelin/pull/2377

    User is no more on zeppelin UI Login page after clicking logout button when 
Zeppelin is running behind proxy server.

    ### What is this PR for?
    The user is no more on Zeppelin UI Login page after clicking logout button 
or links where user doesn't have access to when Zeppelin is running behind a 
proxy server like Nginx.
    
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### What is the Jira issue?
    * [ZEPPELIN-2601](https://issues.apache.org/jira/browse/ZEPPELIN-2601)
    
    ### How should this be tested?
    Set up any reverse proxy server like Nginx, exmaple config below;
    
    ```
    location /abc/def/zeppelin/ {
            proxy_pass http://localhost:8080/;
            proxy_http_version 1.1;
            proxy_set_header Upgrade $http_upgrade;
            proxy_set_header Connection "upgrade";
    }
    ```
    
    And now from browser navigate to this URL, and click on any like for which 
user doesn't have access to. In my example `user1` did not have access to any 
of `/api/interpreter/**` `/api/configurations/**` and `/api/credential/**`
    
    ### Screenshots (if appropriate)
    
    Before:
    
![before](https://cloud.githubusercontent.com/assets/674497/26574347/a204b064-453e-11e7-8799-2c5d38bca5ad.gif)
    
    After:
    
![after](https://cloud.githubusercontent.com/assets/674497/26574348/a20f3412-453e-11e7-97bb-4ffb54c6e985.gif)
    
    
    ### Questions:
    * Does the licenses files need update?
    * Is there breaking changes for older versions?
    * Does this needs documentation?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-2601

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2377.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2377
    
----
commit 03551158d1b0518da927cdb54aced75684148e64
Author: Prabhjyot Singh <prabhjyotsi...@gmail.com>
Date:   2017-05-30T08:13:04Z

    change window.location.replace('/') with window.location = 
baseUrlSrv.getBase()

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to