[GitHub] zeppelin pull request #2450: [ZEPPELIN-2707][DOCS][HOTFIX] fix: broken image...

[1ambda]

GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2450

    [ZEPPELIN-2707][DOCS][HOTFIX] fix: broken image URLs in 0.8.0-SNAPSHOT doc

    ### What is this PR for?
    
    fix: broken image URLs in 0.8.0-SNAPSHOT doc
    
    using images in {{/asset}} (the absolute path) is actually invalid. That's 
because each version has its own image directory. So they should use the 
relative path. `{{BASE_PATH}}`
    
    ```
    ➜  asf-zeppelin tree site | grep asset
    ├── assets # root asset, we shouldn't use it in versioned doc.
    │   │   ├── assets
    │   │   ├── assets
    │   │   ├── assets
    │   │   ├── assets
    │   │   ├── assets
    │   │   ├── assets
    │   │   ├── assets
    │   │   ├── assets
    │   │   ├── assets
    │       ├── assets
    ```
    
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    DONE
    
    ### What is the Jira issue?
    * Open an issue on Jira https://issues.apache.org/jira/browse/ZEPPELIN/
    * Put link here, and add [ZEPPELIN-*Jira number*] in PR title, eg. 
[ZEPPELIN-533]
    
    ### How should this be tested?
    
    1. cd `docs/`
    2. build: `bundle exec jekyll build --safe`
    3. check whether links in `_site` include `/docs/0.8.0-SNAPSHOT` as prefix 
or not
    
    ### Screenshots (if appropriate)
    
    #### Current 
    
http://zeppelin.apache.org/docs/0.8.0-SNAPSHOT/usage/interpreter/overview.html
    
    
![image](https://user-images.githubusercontent.com/4968473/27685112-bcca5846-5d07-11e7-89bb-3965015cf5a5.png)
    
    #### After
    
    
![image](https://user-images.githubusercontent.com/4968473/27685218-3490fad8-5d08-11e7-9133-0e148689986e.png)
    
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin 
ZEPPELIN-2707/should-use-its-own-asset-directory

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2450.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2450
    
----
commit fb70214a9fd1688f8007b3f09c8c1e4105d61502
Author: 1ambda <1am...@gmail.com>
Date:   2017-06-29T11:13:41Z

    fix: Use its own asset dir

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---