Github user zjffdu commented on the issue:
https://github.com/apache/zeppelin/pull/2329
@jongyoul Could you add more javadoc on these new classes and write a
simple summary about the design so that it is easier for other people to review
it ?
And I would suggest you to add unit test for yarn-cluster mode, you can use
MiniYarnCluster for that. Otherwise it is very easy to introduce regression.
https://wiki.apache.org/hadoop/HowToDevelopUnitTests
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
