Hoon Park created ZEPPELIN-2751:
-----------------------------------

             Summary: [FRONT] Convert ng-include to directive (zeppelin-web)
                 Key: ZEPPELIN-2751
                 URL: https://issues.apache.org/jira/browse/ZEPPELIN-2751
             Project: Zeppelin
          Issue Type: Sub-task
          Components: front-end
            Reporter: Hoon Park


ng-include is not portable so it makes hard to get smooth transition for next 
tech stacks

{code}
➜  src git:(ZEPPELIN-2749/use-scalable-file-structure-for-zeppelin-web) ✗ ag 
ng-include
app/home/notebook.html
29:         <li class="filter-names" 
ng-include="'components/filterNoteNames/filter-note-names.html'"></li>
32:               ng-include src="'app/home/notebook-template.html'" 
ng-class="note_folder_renderer"></li>
36:               ng-include src="'app/home/notebook-template.html'" 
ng-class="note_folder_renderer"></li>

app/home/home.html
42:              <li class="filter-names" 
ng-include="'components/filterNoteNames/filter-note-names.html'"></li>
49:                    ng-include src="'app/home/notebook-template.html'" 
ng-class="note_folder_renderer"></li>
53:                    ng-include src="'app/home/notebook-template.html'" 
ng-class="note_folder_renderer"></li>
88:         ng-include src="'app/notebook/paragraph/paragraph.html'"

app/home/notebook-template.html
93:        <li ng-repeat="node in node.children | 
orderBy:node:false:noteComparator" 
ng-include="'app/home/notebook-template.html'" 
ng-class="'note_folder_renderer'"></li>
117:        <li ng-repeat="node in node.children | 
orderBy:node:false:noteComparator" 
ng-include="'app/home/notebook-template.html'" 
ng-class="'note_folder_renderer'"></li>

app/interpreter/interpreter.html
75:          <div ng-include 
src="'app/interpreter/repository-create.html'"></div>
86:  <div ng-include src="'app/interpreter/interpreter-create.html'"></div>

app/jobmanager/jobmanager.html
121:    <div ng-include src="'app/jobmanager/jobs/job.html'"

app/jobmanager/jobs/job.html
17:    <div ng-include src="'app/jobmanager/jobs/job-control.html'"></div>
31:    <div ng-include src="'app/jobmanager/jobs/job-progressBar.html'"></div>

app/notebook/notebook.html
15:<div id="actionbar" ng-include 
src="'app/notebook/notebook-actionBar.html'"></div>
121:         ng-include src="'app/notebook/paragraph/paragraph.html'"

app/notebook/paragraph/paragraph.html
50:    <div ng-include 
src="'app/notebook/paragraph/paragraph-progressBar.html'"></div>
51:    <div ng-include 
src="'app/notebook/paragraph/paragraph-parameterizedQueryForm.html'"></div>
59:         ng-include src="'app/notebook/paragraph/result/result.html'">
66:  <div ng-include 
src="'app/notebook/paragraph/paragraph-control.html'"></div>

app/notebook/paragraph/result/result.html
16:  <div ng-include 
src="'app/notebook/paragraph/result/result-chart-selector.html'"></div>

app/visualization/builtins/visualization-linechart.js
167:      <ng-include 
src="'app/visualization/builtins/visualization-displayXAxis.html'">
168:      </ng-include>`,

components/navbar/navbar-noteList-elem.html
45:              ng-include="'components/navbar/navbar-noteList-elem.html'">

components/navbar/navbar.html
48:              <li class="filter-names" 
ng-include="'components/filterNoteNames/filter-note-names.html'"></li>
51:                  ng-class="{'active' : navbar.isActive(node.id)}" 
ng-include="'components/navbar/navbar-noteList-elem.html'">
56:                  ng-class="{'active' : navbar.isActive(node.id)}" 
ng-include="'components/navbar/navbar-noteList-elem.html'">

index.html
79:    <div ng-include src="'components/navbar/navbar.html'"></div>
85:    <div ng-include 
src="'components/modal-shortcut/modal-shortcut.html'"></div>
87:      <div id="note-modal-container" ng-include 
src="'components/noteName-create/note-name-dialog.html'"></div>
90:      <div id="note-import-container" ng-include 
src="'components/noteName-import/note-import-dialog.html'"></div>
93:      <div id="login-container" ng-include 
src="'components/login/login.html'"></div>
96:      <div ng-include src="'components/rename/rename.html'"></div>

{code}




--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to