GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2472
[ZEPPELIN-2749] Use scalable file structure for zeppelin web
### What is this PR for?
We have improved zeppelin-web, but some parts are still messy. As part of
keeping zeppelin-web module healthy
([ZEPPELIN-2725](https://issues.apache.org/jira/browse/ZEPPELIN-2725)), I
suggest having these file structure. (Refer the screenshot section)
Here are few reasons.
- unified directory, file name helps us to recognize, find which part we
should modify / fix
- [this
structure](https://github.com/toddmotto/angularjs-styleguide#file-naming-conventions)
is what the angularjs community has verified for few years. so newly joined
developers can feel more comfortable.
- this is necessary for [Modular
archiecture](https://issues.apache.org/jira/browse/ZEPPELIN-2750) and it
eventually helps us to make a smooth transition toward next technologies (even
whatever we will use)
Additionally,
- This is not the meaningless refactoring PR and doesn't block developing
new features / fixes (Please refer the `Some Details` section)
- I will handle conflicts for few days would be brought by other WIPs
For your information,
- https://github.com/toddmotto/angularjs-styleguide#file-naming-conventions
-
https://github.com/johnpapa/angular-styleguide/blob/master/a1/README.md#naming
#### How to Review This PR?
Please follow the commits. I modified submodules by splitting commits. Thus
commit message includes what has been done in that PR. For example,
#### Some Details
- Didn't change the widely used variable names not to make many conflicts.
For example, `websocketMsgSrv`, `arrayOrderingSrv`
- Since there are helium packages already published, didn't changed the
html names like `pivot_setting.html` (it's better to use `pivot-setting.html`
if we following the rule)
### What type of PR is it?
[Improvement | Refactoring]
### Todos
Please refer the commit message.
### What is the Jira issue?
[ZEPPELIN-2749](https://issues.apache.org/jira/browse/ZEPPELIN-2749)
### How should this be tested?
**All functionalities must work** as like before, CI will test it.
### Screenshots (if appropriate)
#### Before: messy, mixed directory structure
#### After: only the shared components will be placed under `components/`
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin
ZEPPELIN-2749/use-scalable-file-structure-for-zeppelin-web
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2472.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2472
----
commit c1c210de28579bb0ada8f2b64434f0914e78274a
Author: 1ambda <[email protected]>
Date: 2017-07-09T03:12:27Z
rename: repository-dialog -> repository-create
commit a9a6368a663fce28e8c62a7cebed647fa52075a8
Author: 1ambda <[email protected]>
Date: 2017-07-09T03:14:41Z
fix: remove useless dir interpreter-create
commit 4e7f6d9c1119a1f82cb34596d089a8c6ef919594
Author: 1ambda <[email protected]>
Date: 2017-07-09T03:16:25Z
fix: Move repository-create into interpreter/
commit d7d7434a722ef161289b043f42e5051581fb51bf
Author: 1ambda <[email protected]>
Date: 2017-07-09T03:31:06Z
move: note specific service saveAsService into notebook/
commit 3f02c5038cd723cc4882c87e8194033ff1ff816b
Author: 1ambda <[email protected]>
Date: 2017-07-09T03:33:10Z
fix: Remove unused saveAsService from paragraph ctrl
commit 701f44320b44675b60f00ab80542944fbc7902fe
Author: 1ambda <[email protected]>
Date: 2017-07-09T03:39:52Z
move: note specific service into notebook/
commit ad99c04b7c0216dabcf01ba3705e30f7c46fc68c
Author: 1ambda <[email protected]>
Date: 2017-07-09T03:50:02Z
move: note specific dialog into notebook/
commit c21a1237bc2cee4bc8e1fe5e5aef97c68bc9ac1e
Author: 1ambda <[email protected]>
Date: 2017-07-09T03:58:42Z
move: paragraph specific ctrl into paragraph/
commit a25275307e373737b465b349d8f9d9f0d25133bc
Author: 1ambda <[email protected]>
Date: 2017-07-09T04:02:04Z
fix: Remove meaningless postfix from searchService
commit 0611aff5e46c17eb0abc4baf6a5ffd68057e4da6
Author: 1ambda <[email protected]>
Date: 2017-07-09T04:06:04Z
websocket: Rename funcs
commit 406439977fb686f44002a0d3bda503955bbad3a3
Author: 1ambda <[email protected]>
Date: 2017-07-09T04:09:37Z
fix: Remove useless postfix and rename files, funcs
commit bfcd6b8554b713219937948dff42045ac93c4fae
Author: 1ambda <[email protected]>
Date: 2017-07-09T04:15:48Z
resizable: Rename funcs
commit d3132e9a8a9de8cf11a69303511570e75253d569
Author: 1ambda <[email protected]>
Date: 2017-07-09T04:27:52Z
note-list: Remove useless middle word Data
commit b9f3c17897a176c22e5332cbc8b5cf899073568c
Author: 1ambda <[email protected]>
Date: 2017-07-09T04:32:47Z
note-list-elem: Rename
commit d3da2d45e469597022ba254445d163cd3e6e23ae
Author: 1ambda <[email protected]>
Date: 2017-07-09T04:36:28Z
note-action: Rename files, funcs
commit 1f9509434070ae1a34476b6c467fcca0445c682a
Author: 1ambda <[email protected]>
Date: 2017-07-09T04:39:56Z
note-action: Rename injected service name
commit e993133a3e2c6ddfca5d5f82f12b6ddcd656b7ba
Author: 1ambda <[email protected]>
Date: 2017-07-09T04:42:26Z
rename: Rename funcs
commit 40f62e3c003c5ef378c5c8122980adc919fab6b9
Author: 1ambda <[email protected]>
Date: 2017-07-09T04:43:49Z
rename: Modify injected service name
commit b5dff142b582aaf31e78d2e0861739a240d01726
Author: 1ambda <[email protected]>
Date: 2017-07-09T05:37:40Z
resizable: Move para specific directive into paragraph/
commit 7a0948414ee592be0610b640b4cda5f5b9ce0e5e
Author: 1ambda <[email protected]>
Date: 2017-07-09T05:51:33Z
browser-detect: move save-as specific service into save-as/
commit a40ea23ce15968fb37aab59ebe8a5cb661f2c04d
Author: 1ambda <[email protected]>
Date: 2017-07-09T05:59:29Z
search: Move search specific service into serach/
commit abf6869d06d24d99795affdbfabef66ce72c6520
Author: 1ambda <[email protected]>
Date: 2017-07-09T06:03:32Z
note-import: Rename files
commit b0a36a7e8e68d5384f9eac9e1e462b5133a311e1
Author: 1ambda <[email protected]>
Date: 2017-07-09T07:06:10Z
note-import: Remove meaningless postfix dialog
commit e17c7ee74f89d8fc6961b8517b318b31f7334efd
Author: 1ambda <[email protected]>
Date: 2017-07-09T07:12:56Z
note-create: Remove useless dialog postfix
commit c34024491eae8d68692d75242e4480f9e9cb13bd
Author: 1ambda <[email protected]>
Date: 2017-07-09T07:15:56Z
note-create: Rename files
commit 568149ed36467a83d80d36e558af40e2e246f2e3
Author: 1ambda <[email protected]>
Date: 2017-07-09T08:36:05Z
note-create: Rename injected controller
commit 07b1f3ffde7d9cff9fb4c262f88ccc307fc4ef29
Author: 1ambda <[email protected]>
Date: 2017-07-09T08:38:44Z
note-create: Rename to noteCreateModal
commit b2bf91b02c45027d0df05e2194cdb8df24bc148a
Author: 1ambda <[email protected]>
Date: 2017-07-09T08:41:27Z
note-import: Rename to noteImportCtrl
commit 8bc7812412afb97650a6c04f1cfa3b786dfe13a9
Author: 1ambda <[email protected]>
Date: 2017-07-09T08:45:12Z
login: Remove invalid attr in login
commit 47ac45d1ac66c0382589de26a920473cd4d267ed
Author: 1ambda <[email protected]>
Date: 2017-07-09T08:52:50Z
expand-collapse: Move navbar specific directive into navbar/
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
