GitHub user khalidhuseynov reopened a pull request: https://github.com/apache/zeppelin/pull/2374
[ZEPPELIN-2593] Add storage settings to persist on run and commit ### What is this PR for? adding settings to storage layer to let user choose to persist continuously or only on commits ### What type of PR is it? Improvement | Feature ### Todos * [x] - add notebook repo setting * [x] - add persist on run & commit (checkpoint) * [x] - add persist on commit (checkpoint) only * [x] - add tests ### What is the Jira issue? [ZEPPELIN-2593](https://issues.apache.org/jira/browse/ZEPPELIN-2593) ### How should this be tested? 1. go to notebook repo menu and click on edit `Global settings` or do through env var `ZEPPELIN_NOTEBOOK_PERSISTENCE` 2. change value of `Note persistence` item to `Persist on note run and commits` or change value of `ZEPPELIN_NOTEBOOK_PERSISTENCE` into "run" 3. go change any note, although it will be changed in memory, it won't be persisted 4. to check above can reload notes in note list view -> will see original note 5. can save note either by `Run` or clicking `Commit` button in version control menu of note ### Screenshots (if appropriate) <img width="1191" alt="screen shot 2017-07-10 at 3 02 02 am" src="https://user-images.githubusercontent.com/1642088/27996389-fd0a4a26-651b-11e7-91ed-ea22d135f875.png"> ## Questions: * Does the licenses files need update? no * Is there breaking changes for older versions? no * Does this needs documentation? no You can merge this pull request into a Git repository by running: $ git pull https://github.com/khalidhuseynov/zeppelin feat/ZEPPELIN-2593 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zeppelin/pull/2374.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #2374 ---- commit 856fceed1b39e49461e68b1d97f1f736b1101f3a Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-05-29T07:48:06Z initial flow commit ea82c9919f84252e7f4c0fce8d4a6d1cfe9a2bff Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-06-09T07:14:07Z add temp test commit 1fd869a27e31ecadf271b483b951623801b312fd Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-06-09T10:39:02Z rework settings into global commit dec53aeb44c7f1a97133511730b71ba24a8a94fe Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-06-12T05:16:10Z change checkpoint signature with recent note commit 6b2ce75009bdb19b5df9e8c4ba46c1fcf3637076 Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-06-12T05:16:55Z improve test commit 298edf07b18501325a00c980ed9b5e97547270d8 Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-06-12T06:42:01Z add large test for global setting change commit 1be654a3d4c3ccdc32ed7020a5a4aa2bc8ea4ce8 Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-06-12T08:52:02Z add save & commit from note action bar commit c283c00a207786d595d217ec3893c2ccab8527b5 Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-06-12T12:31:32Z fix test, set property back commit 5f24004096b0fa043173238a0ed9f976adf75cfb Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-06-12T13:34:01Z move setting from global to per repo and apply to remote s3 and zh commit a6f572be272d458217858937a3ef4ecdfcfd96cc Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-06-26T18:22:20Z add conditional save in s3 commit d04452a214709e3e5dbe40b19030369adc1e2a99 Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-06-30T08:11:28Z fix spelling commit fca6d4a570c8f1f1a146be6afde3a25277c9395d Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-06-30T09:29:04Z make option as non-actionable, don't broadcast commit f912f83db174359df1cbd450e1f0b597321dd949 Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-06-30T10:47:10Z send note inside checkpoint payload commit 5d1b66ca9afede6801046ee5c390a2372020d93b Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-06-30T11:37:49Z fix test commit 6ab2e1e434a3326f22c938a7e7ebdddb6d3234f4 Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-07-06T14:06:21Z separate persist for run and update actions in notebook commit a44caa85ff27887ea0cc200c3f4db36f8a75a013 Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-07-06T17:34:49Z change env var name with 3 default values commit 3d1ea5393bfce9ea8ef31a77932974aef13a9809 Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-07-07T01:48:44Z move settings to base class commit 0c3d97099f4e4f0a5d207815cdb341531c351846 Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-07-07T05:51:13Z add rest test for setting update commit 846a3d13031023408fd6e723afafecc1c2cab679 Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-07-09T10:50:05Z add basic test for persist on run in notebook commit 60a8bc872c594120edd5c77c7f733e64e2d6c0ab Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-07-09T11:31:54Z add save in checkpoint storages commit 0335a33f154c3fa3564fe8d3774397d7e2dfddd8 Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-07-09T12:59:50Z substitute noteId->note in checkpoint commit 2a0ad85a9cfcd307b2db40aae75c951fd1b0f2cc Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-07-09T15:20:05Z refactor setting utils under util package commit 82d44786394000ff26c4c27a90b84bb7c2eba3c3 Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-07-09T16:18:00Z change persist values to enum type commit 217ddf82e686200697a22e102921a0421ec8295c Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-07-09T16:29:24Z don't save if commit only enabled commit 15886020be3a2fb8298097dbb3fa9a8f6d868875 Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-07-09T16:29:50Z reflect the description correctly commit 232ad96969a6f926d3b65ad5cf7d9c11097002f4 Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-07-09T16:39:04Z add check to test commit 1066c346e39c71cbb8c4834f241408eae6c45efd Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-07-09T17:02:59Z restore original Commit, remove Save & Commit msg commit e3636b44a421562bef7d225b8d58f1fee6746658 Author: Khalid Huseynov <khalid...@gmail.com> Date: 2017-07-09T17:37:45Z fix checkstyle ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---