GitHub user dabaitu opened a pull request:
https://github.com/apache/zeppelin/pull/2479
[ZEPPELIN-2762] Use regex to retrieve interpreter/repl name, and to
retrieve property key; add and fix tests
### What is this PR for?
Make logic to parse interpreter or repl name more robust by using regex.
Make logic to parse property name in JDBC interpreter more robust by using
regex.
Add tests for cases missed before that the regexes would catch now.
Fix failing tests in Paragraph and JDBCInterpreter.
### What type of PR is it?
[Bug Fix | Improvement]
### Todos
* [ ] - Task
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-2762
### How should this be tested?
Appropriate unit tests should be added to fully test regexes. They are
added as part of this PR.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dabaitu/zeppelin master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2479.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2479
----
commit 3e36eec42b07040b25f92320ab5cf3aadabc5799
Author: thomass <[email protected]>
Date: 2017-07-10T23:34:01Z
Use regex to retrieve interpreter/repl name, and to retrieve property key;
add and fix tests
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
