GitHub user herval opened a pull request:

    https://github.com/apache/zeppelin/pull/2503

    [ZEPPELIN-2808] remember me support

    ### What is this PR for?
    Add support for "remember me" cookies, so we can activate LDAP without 
forcing users to re-login every time
    
    
    ### What type of PR is it?
    Improvement
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-2808
    
    ### How should this be tested?
    - Activate "rememberMe" by following the steps on the `shiro.ini.template`
    - Log in with the "remember me" option checked
    - Close the browser
    - Reopen the browser
    - You should still be logged in
    
    ### Questions:
    * While this is standard behavior on many web-apps, some folks (as 
exemplified on the Shiro documentation) find it "not secure". I'd like to know 
Zeppelin folks' opinion on this.
    * The "remember me" checkbox will show, regardless of whether you configure 
the rememberMeManager or not. Should this be a default? Should we hide it from 
the UI based on some config?


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/herval/zeppelin remember-me

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2503.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2503
    
----
commit a0a5437d75282b60686f915436cb96e4cb661a8d
Author: Herval Freire <hfre...@twitter.com>
Date:   2017-07-25T20:07:25Z

    [ZEPPELIN-2808] remember me support

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to