GitHub user sadhen opened a pull request:

    https://github.com/apache/zeppelin/pull/2544

    [ZEPPELIN-2724] Another Attempt to solve the dead lock problem

    ### What is this PR for?
    https://github.com/apache/zeppelin/pull/2465
    
    This is my attempt under the help with my colleague. We originally wrote 
the patch in Java 8 based on Zeppelin 0.6.0. Today, I rewrite this part in Java 
7 based on Zeppelin master. I confirm the code I wrote for Zeppelin 0.6.0 
solved the dead lock problem. We have over 80 websocket connections for several 
months and our Zeppelin 0.6.0 works well and didn't crash for websocket reason 
since we apply the patch.
    
    I will explain the patch in detail if necessary.
    
    ### What type of PR is it?
    [ Improvement ]
    
    ### Todos
    * [ ] - To be verified
    
    ### How should this be tested?
    Our QA wrote a python script, I will post it here later.
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/wacai/zeppelin websocket

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2544.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2544
    
----
commit 82ec4e0efc49daa60aed9f54bf42ff991a7873f9
Author: 忍冬 <rend...@wacai.com>
Date:   2017-08-15T13:44:47Z

    change notebook-authorization.json and interpreter.json to NotebookDir for 
dockerization

commit be8877cb4323d8a4e76f4a15ec9675f00396a5f6
Author: 忍冬 <rend...@wacai.com>
Date:   2017-08-16T03:04:14Z

    update corresponding comments and configs

commit 9e21f0e2518f1899fbd8c891b89d74ee03b1f9e8
Author: 忍冬 <rend...@wacai.com>
Date:   2017-08-16T03:22:55Z

    fix

commit d7a6d71d9af011f9fd2ebf2be813a60b8118924b
Author: 忍冬 <rend...@wacai.com>
Date:   2017-08-16T06:07:39Z

    fix unit test

commit 6afb733515620bf0bd4a6b43abe6344ad24bdc16
Author: 忍冬 <rend...@wacai.com>
Date:   2017-08-16T06:29:27Z

    fix unit test  on NoteInterpreterLoaderTest

commit 58013e34cf298c7ba343a21742c809be3c95850a
Author: 忍冬 <rend...@wacai.com>
Date:   2017-08-21T07:45:40Z

    some logging and make broadcast concurrent

commit 3c017eca125cebb5a4dc1cf8406852d83420aee9
Author: 忍冬 <rend...@wacai.com>
Date:   2017-08-21T09:33:04Z

    refactor on noteSocketMap

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to