GitHub user 1ambda opened a pull request:
https://github.com/apache/zeppelin/pull/2573
[ZEPPELIN-2920] move commonly used error handlers to util (FRONT)
### What is this PR for?
Sometimes I can see manually written error handler and it's repeated again
and again.
Even sometimes I can see missing 401 (unauthorized error) handler. So I
propose here generalizing error handler for frontend.
### What type of PR is it?
[Improvement | Refactoring]
### What is the Jira issue?
[ZEPPELIN-2920](https://issues.apache.org/jira/browse/ZEPPELIN-2920)
### How should this be tested?
Add `error-handler.service.test.js` and CI will test it.
If you can test manually, u can easily reproduce errornous respsone by
toggling offline in chrome developer tool like.
### Questions:
* Does the licenses files need update? - NO
* Is there breaking changes for older versions? - NO
* Does this needs documentation? - NO
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/1ambda/zeppelin
ZEPPELIN-2920/refactor-add-error-handler-service
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2573.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2573
----
commit 3ca554e02cf87e7e7e21f1734b516de82b0c30e7
Author: 1ambda <[email protected]>
Date: 2017-09-08T07:00:29Z
fix: Add error-handler service
commit 1a8142bfb834b6abdc80e73055f2cbd0166eaab7
Author: 1ambda <[email protected]>
Date: 2017-09-08T07:00:36Z
fix: Apply error-handler service
----
---
