GitHub user tinkoff-dwh opened a pull request:
https://github.com/apache/zeppelin/pull/2615
[ZEPPELIN-1999][IMPROVEMENT] improve replacement
### What is this PR for?
Field `protected Properties property` is protected. sometimes this field
used derictly. Sometimes interpreter is called from another insterpreter (for
ex. Spark, SparkInterpreter creates spark context and calls PySpark). This
improvement fix it problems with context parameters replacement into properties.
### What type of PR is it?
Improvement
### How should this be tested?
1) Setting Spark interpreter
set property 'spark.app.name=#{noteId}'
2) Run paragraph
```%pyspark
print(sc._conf.get("spark.app.name"))
```
3) Check result (note id)
4) Open http://localhost:4040/environment/ (spark ui), check property
`spark.app.name` = note id
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tinkoff-dwh/zeppelin ZEPPELIN-1999-FIX
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/2615.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #2615
----
commit 2447adcd6cb06ddf674ed19013c7464266eeabac
Author: tinkoff-dwh <[email protected]>
Date: 2017-09-14T11:47:12Z
[ZEPPELIN-1999-fix] fix replace parameters. add integrations tests
commit 00725bf4f9aa26c3cbf2c20ee3fffd7094b99c9c
Author: tinkoff-dwh <[email protected]>
Date: 2017-09-17T11:16:29Z
[ZEPPELIN-1999-fix] fix replace parameters
commit 42590c914afbc169ec75af4c3a809f6e3f27eb43
Author: tinkoff-dwh <[email protected]>
Date: 2017-10-10T14:29:53Z
Merge remote-tracking branch 'upstream/master' into ZEPPELIN-1999-FIX
commit 683b3c1e1258d56399dc48e0bf3a10de66f0c83d
Author: tinkoff-dwh <[email protected]>
Date: 2017-10-10T15:29:02Z
[ZEPPELIN-1999-FIX] fix tests
----
---