GitHub user tessbianchi opened a pull request:

    https://github.com/apache/zeppelin/pull/2677

    [ZEPPELIN-3062] Removes ctrl+s default behavior from notebook

    ### What is this PR for?
    As a programmer I habitually press CTRL + S out of fear for my sanity.
    Other web text editing tools (google docs, jupyter notebooks) ignore the 
base functionality of CTRL + S of saving the HTML page, and do nothing instead.
    This is a small change that will makes the user experience of Zeppelin 
notebooks much much better.
    
    ### What type of PR is it?
    Improvement 
    
    ### Todos
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-3062
    
    ### How should this be tested?
    * I tested manually:
    1. Ran `yarn run dev`
    2. Went to `localhost:9000`
    3. Created a new note, now anytime a user presses 'CTRL+S' in the scope of 
the note nothing happens, and the user can continue coding uninterrupted.
    
    ### Screenshots (if appropriate)
    
    ### Questions:


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tessbianchi/zeppelin ZEPPELIN-3062

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2677.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2677
    
----
commit d7e3315f58743217a1ef46d5a8195ae3e805d880
Author: Tess <tesshbian...@gmail.com>
Date:   2017-11-01T00:48:45Z

    Removes ctrl+s default behavior from notebook

----


---

Reply via email to