GitHub user bushnoh opened a pull request:

    https://github.com/apache/zeppelin/pull/2701

    [ZEPPELIN-3098] Livy Interpreter fails if row contains newline or tab

    ### What is this PR for?
    This PR fixes the issue of newlines and tabs breaking results in the SQL 
interpreter in Livy.
    
    The Livy interpreter will return incorrect results if a row contains \n or 
\t characters.
    In the case of the newline, the result will be:
    Line is missing from results if the \n appears anywhere but the end of a 
cell
    `String index out of range: 17` if it appears at the end of a cell
    In the case of the tab, the result will be misaligned columns if the tab 
appears in the middle of a cell
    The output showing these error is attached.
    
    I have changed the parsing and any newline or tab characters will be escaped
    
    ### What type of PR is it?
    Bug Fix 
    
    ### What is the Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-3098
    
    ### How should this be tested?
    Unittests have been added
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bushnoh/zeppelin zeppelin-3098

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2701.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2701
    
----
commit 64a42bea4b38b5cb8087b5d2a14fd7f0e16d4037
Author: Alex Bush <alex.b...@coxauto.co.uk>
Date:   2017-12-08T18:06:57Z

    Fix for newline and tab in data

commit d054af0f0b164c3a74a8c71996a2e1bca526c6a3
Author: Alex Bush <alex.b...@coxauto.co.uk>
Date:   2017-12-08T20:51:00Z

    Force a dummy change for Travis

commit 31cdbdc73b37a6f2a2c2ded701b19971552c52fc
Author: Alex Bush <alex.b...@coxauto.co.uk>
Date:   2017-12-08T20:58:50Z

    Added another comment explaining the regexp change

----


---

Reply via email to