GitHub user prabhjyotsingh opened a pull request:

    https://github.com/apache/zeppelin/pull/2804

    [DISCUSS] semicolons in javascript

    ## What is this PR for?
    Have added this PR to discuss if we should add a rule in eslinerc to have 
semicolons in javascript source
    
    ### What type of PR is it?
    [Improvement | Refactoring]
    
    ### How should this be tested?
    
    ```
    cd zeppelin-web
    npm install (or yarn install if you have yarn)
    npm run lint:once
    ```


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/zeppelin 
discuss/eslint_semi_rule

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2804.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2804
    
----
commit e15b0e6d7685b4b2ab6206871f076ad0ba2aebf6
Author: Prabhjyot Singh <prabhjyotsingh@...>
Date:   2018-02-15T06:46:25Z

    add `"semi": [2, "always"]` rule in eslinerc
    
    Change-Id: If0356e494152c1beb8b8cef666c95d448a490749

----


---

Reply via email to