[GitHub] zeppelin issue #2404: fix bugs for: when interpreter setting restart of one ...

[jongyoul]

Github user jongyoul commented on the issue:

    https://github.com/apache/zeppelin/pull/2404
  
    Hi,
    
    If you tell about the behaviours of restarting interpreter in a interpreter
    setting page, it’s intened behaviours. Here’s the reason. In case of 
‘per
    user’, we can specify which user click the button, so we can restart
    specific user’s interpreter. But, in case of ‘per note’, we cannot 
specify
    which note’s interpreter user want to restart it/them. So in this case, we
    decide to restart all interpreters because of not specifying interpreters.
    At that time, we considered providing same behaviours. That’s the reason
    why we restart all interpreters of ‘per user’, too.
    
    And to avoid this inconvenience, user can restart hos/her own interpreter
    in a note. When user click the restart button in a note, specific
    interpreter will be restarted without stoping others’ ones.
    
    I’ll update docs for it.
    
    On Tue, 13 Mar 2018 at 11:55 AM Eric Charles <notificati...@github.com>
    wrote:
    
    > I have just worked on this issue and found a bug in the InterpreterSetting
    > class. The getInterpreterSessionId uses option.perNoteScoped in its
    > tests, but it should be option.perNoteIsolated. With the below change,
    > the paragraphs are not more aborted and each users benefit from a 
separated
    > scheduler (for now, the jobs of the different users have to queue as they
    > have a single scheduler).
    >
    >   private String getInterpreterSessionId(String user, String noteId) {
    >     String key;
    >     if (option.isExistingProcess()) {
    >       key = Constants.EXISTING_PROCESS;
    >     } else if (option.perNoteIsolated() && option.perUserIsolated()) {
    >       key = user + ":" + noteId;
    >     } else if (option.perUserIsolated()) {
    >       key = user;
    >     } else if (option.perNoteIsolated()) {
    >       key = noteId;
    >     } else {
    >       key = SHARED_SESSION;
    >     }
    >     return key;
    >   }
    >
    > —
    > You are receiving this because you were mentioned.
    > Reply to this email directly, view it on GitHub
    > <https://github.com/apache/zeppelin/pull/2404#issuecomment-372529822>, or 
mute
    > the thread
    > 
<https://github.com/notifications/unsubscribe-auth/ADcflssq3iPpHuetQ_CwwX1Lbg8AWmhcks5tdzUFgaJpZM4N2VEW>
    > .
    >
    -- 
    이종열, Jongyoul Lee, 李宗烈
    http://madeng.net



---