GitHub user prabhjyotsingh opened a pull request:

    https://github.com/apache/zeppelin/pull/2872

    [ZEPPELIN-3089] Delete all notes for current user

    ### What is this PR for?
    "Empty Trash" is not working when multi-user create a notebook and move it 
to trash.
    Because all notebooks are in the same trash folder even though the user 
doesn't have permission to the notebook, and on clicking "Empty Trash" button 
next to Trash folder, Zeppelin tries to delete all notebooks in the Trash 
folder, which includes no permission notebook, but cannot delete those because 
of no permission.
    
    This has slightly different implementation than that is there is 
https://github.com/apache/zeppelin/pull/2695
    
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * [ ] - Add unit test case
    
    ### What is the Jira issue?
    * [ZEPPELIN-3089](https://issues.apache.org/jira/browse/ZEPPELIN-3089)
    
    ### How should this be tested?
    * Login as user 'A' and create a notebook 'A'
    * Move notebook 'A' to Trash
    * Login as user 'B' and create a notebook 'B'
    * Move notebook 'B' to Trash
    * Click 'Empty Trash' button next to 'Trash' folder
    
    
    ### Screenshots (if appropriate)
    
![zeppelin-3249-python](https://user-images.githubusercontent.com/674497/37451922-229533ea-2859-11e8-9a76-085c5cb8b9d1.gif)
    
    ### Questions:
    * Does the licenses files need update? N/A
    * Is there breaking changes for older versions? N/A
    * Does this needs documentation? N/A


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/prabhjyotsingh/zeppelin ZEPPELIN-3089

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2872.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2872
    
----
commit 971cbf6727f45da79653c3030aea35b7563f3467
Author: Prabhjyot Singh <prabhjyotsingh@...>
Date:   2018-03-15T07:58:36Z

    ZEPPELIN-3089: Delete all notes for current user
    
    Change-Id: I5cb685c7e78852f1e2bc146d988b99aaf68ae6df

----


---

Reply via email to