GitHub user sanjaydasgupta opened a pull request:

    https://github.com/apache/zeppelin/pull/2967

    [ZEPPELIN-3438] Passing Z variables to BigQuery interpreter

    ### What is this PR for?
    
    This PR enables the interpolation of ZeppelinContext objects into the 
paragraph text of BigQuery cells. It also introduces a new interpreter-level 
configuration parameter named zeppelin.bigquery.interpolation. This new 
parameter is false by default, and must be set to true to enable object 
interpolation. The default value of false guarantees backward compatibility for 
users who are not aware of the new feature.
    
    The implementation takes the same approach that was followed in PR 
[2898](https://github.com/apache/zeppelin/pull/2898) and 
[2903](https://github.com/apache/zeppelin/pull/2903).
    
    ### What type of PR is it?
    
    [Feature]
    
    ### Todos
    
    * [ ] - Task
    
    ### What is the Jira issue?
    
    https://issues.apache.org/jira/browse/ZEPPELIN-3438
    
    ### How should this be tested?
    
    Two new unit test classes have been added: 
[BigQueryInterpolationDefaultTest.java](https://github.com/apache/zeppelin/compare/master...sanjaydasgupta:zeppelin-3438-z-variables-for-bigquery?expand=1#diff-d3e3900a3a067da0f1c9863b026c13c7),
 and 
[BigQueryInterpolationEnabledTest.java].(https://github.com/apache/zeppelin/compare/master...sanjaydasgupta:zeppelin-3438-z-variables-for-bigquery?expand=1#diff-a590dc5b78e2eae05ab5c7bda8dcc028)
    
    Also, the code in this PR merely causes the BigQuery interpreter to 
"opt-in" to the implementation already existing in the Interpreter base class - 
described in [PR-2898](https://github.com/apache/zeppelin/pull/2898). The unit 
tests necessary are already present in PR-2898
    
    ### Screenshots (if appropriate)
    
    ### Questions:
    
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? Yes, documentation changes provided in 
[bigquery.md](https://github.com/apache/zeppelin/compare/master...sanjaydasgupta:zeppelin-3438-z-variables-for-bigquery?expand=1#diff-dae0efb0a1eda2c293e809843480c781)


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sanjaydasgupta/zeppelin 
zeppelin-3438-z-variables-for-bigquery

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2967.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2967
    
----
commit 92c749e9b7d5261f5e50a5cfa79eae55c9530b05
Author: Sanjay Dasgupta <sanjay.dasgupta@...>
Date:   2018-05-14T02:02:26Z

    zeppelin-3438 z-variables-for-BigQuery

----


---

Reply via email to