GitHub user fsteinle opened a pull request:

    https://github.com/apache/zeppelin/pull/3098

    ZEPPELIN-3664

    * Return "userPrincipalName" from ActiveDirectoryGroupRealm when searching 
for users.
    * Added unit test for search functionality.
    
    ### What is this PR for?
    Fix for https://issues.apache.org/jira/browse/ZEPPELIN-3664
    Return the "userPrincipalName" instead of the "cn" (common name) from 
ActiveDirectoryGroupRealm when searching users to set note permissions.
    
    ### What type of PR is it?
    [Bug Fix]
    
    ### Todos
    * -
    
    ### What is the Jira issue?
    * https://issues.apache.org/jira/browse/ZEPPELIN-3664
    
    ### How should this be tested?
    Steps to reproduce
    1. Configure connection to AD with 
org.apache.zeppelin.realm.ActiveDirectoryGroupRealm
    2. Login to Zeppelin
    3. Create new notebook
    4. Edit the permissions and start typing the name of a AD user to one of 
the permission fields
    5. Select one of the suggestions and save
    6. Check the content of "notebook-authorization.json"
    
    Expected result
    * The "userPrincipalName" of the user is shown in the suggestion box and 
written to "notebook-authorization.json" (see screenshot attached).
    
    Actual result
    * The "cn" (common name) of the user is shown in the suggestion box and 
written to "notebook-authorization.json".
    
    ### Screenshots
    
![notepermission](https://user-images.githubusercontent.com/41739962/43268484-13c09516-90f1-11e8-9967-4513c668b4e5.png)
    
    ### Questions:
    * Does the licenses files need update? - No
    * Is there breaking changes for older versions? - No
    * Does this needs documentation? - No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/fsteinle/zeppelin master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/3098.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #3098
    
----
commit 2daec7c590d39f21c2d437f56ddea0a51bcd0e8f
Author: fsteinle <steinle@...>
Date:   2018-07-26T14:22:24Z

    ZEPPELIN-3664:
    * Return "userPrincipalName" from ActiveDirectoryGroupRealm when searching 
for users.
    * Added unit test for search functionality.

----


---

Reply via email to