GitHub user 88sanjay reopened a pull request:
https://github.com/apache/zeppelin/pull/3207
[ZEPPELIN-3825] Allow custom service account for GCSNotebookRepo
### What is this PR for?
The current implementation uses the default google applications service
account to establish a connection with GCS. We cannot specify a custom service
account for the connection with the existing implementation. This PR enables
the same.
* Added ZEPPELIN_NOTEBOOK_GCS_CREDENTIALS_FILE to ConfVars
* Added functionality in GCSNotebookRepo and OldGCSNotebookRepo
to get credentials from CREDENTIALS_FILE
* Updated doc string and documentation
### What type of PR is it?
[Improvement]
### Todos
* None
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3825
### How should this be tested?
* Create a new service account that has access to write to google cloud
storage.
* Disable Google Storage access to the default application service account.
* Build and deploy zeppelin after updating
zeppelin.notebook.gcs.credentialsJsonFilePath in zeppelin-site.xml
* Validate that new notes are being written to GCS bucket
### Screenshots (if appropriate)
* None
### Questions:
* Does the licenses files need update? -No
* Is there breaking changes for older versions? - No
* Does this needs documentation? - Yes. Existing documentation has been
updated to reflect the same.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/88sanjay/zeppelin ZEPPELIN-3825
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3207.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3207
----
commit 84b8da4d5b07ad3464713f651a82db6bb7243041
Author: sanjaykumar <sanjay.kumar@...>
Date: 2018-10-22T22:49:39Z
ZEPPELIN-3825. Allow custom service account for GCSNotebookRepo
* Added ZEPPELIN_NOTEBOOK_GCS_CREDENTIALS_FILE to ConfVars
* Added functionality in GCSNotebookRepo and OldGCSNotebookRepo
to get credentials from CREDENTIALS_FILE
* Updated doc string and documentation
commit 15c8aa0fba022e3da90043fdcb821a095bc38069
Author: sanjaykumar <sanjay.kumar@...>
Date: 2018-11-05T16:55:55Z
Merge branch 'master' into ZEPPELIN-3825
----
---
