GitHub user jongyoul opened a pull request:
https://github.com/apache/zeppelin/pull/3246
ZEPPELIN-3892 Make SecurityUtils as a service
### What is this PR for?
Making SecurityService more configurable. Currently, SecurityUtils consists
of static methods, and which means it's not extendable and pluggable. It would
be better if users could implement new security features easily.
### What type of PR is it?
[Refactoring]
### Todos
* [x] - Introduce `SecurityService` as an interface to support security
features
* [x] - Move `SecurityUtils` to `ShiroSecurityService` as an implementation
of `SecurityService`
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-3892
### How should this be tested?
* This is a refactoring. It should pass all of the current tests
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/zeppelin ZEPPELIN-3892
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3246.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3246
----
commit 422d169fa3df35ea0b1ee72084a88c7651f7943a
Author: Jongyoul Lee <jongyoul@...>
Date: 2018-12-03T01:53:53Z
Introduce an interface of SecurityService to handle issues of securities
Change SecurityUtils to ShiroSecurityService
Introduce NoSecurityService to divide to handle without shiro configuration
commit 723c388c680e121ca1f0dedaeb68e21a522aaa31
Author: Jongyoul Lee <jongyoul@...>
Date: 2018-12-03T01:56:34Z
Add licenses
commit fa2dd487856fc3bc04478d756103df5d9badac4a
Author: Jongyoul Lee <jongyoul@...>
Date: 2018-12-03T02:06:12Z
Move validation logic for shiro to ShiroSecurityService
commit 932b1f6783be3a84598bcfce8b35c8b889840c2e
Author: Jongyoul Lee <jongyoul@...>
Date: 2018-12-03T02:25:36Z
Add license
----
---
