GitHub user jongyoul opened a pull request:
https://github.com/apache/zeppelin/pull/3267
[WIP][MINOR] Refactoring `ZeppelinServer` to adopt DI
### What is this PR for?
Clarifying the structure of ZeppelinServer and related classes.
### What type of PR is it?
[Refactoring]
### Todos
* [x] - Adopt DI on Zeppelin server
### What is the Jira issue?
Minor
### How should this be tested?
All CI should be passed
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jongyoul/zeppelin minor/inject-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zeppelin/pull/3267.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3267
----
commit b7d033291ec990811024fb3dce82581d6a5e3080
Author: Jongyoul Lee <jongyoul@...>
Date: 2018-12-14T08:52:37Z
WIP DI
commit be42fd9a485dd8c9bbb84f2495dbafbe8d58a0a4
Author: Jongyoul Lee <jongyoul@...>
Date: 2018-12-16T11:34:54Z
Uncomment the commented before
commit d8ddf71484d2e7b728f2fc25ceeb8f4f2b33f31b
Author: Jongyoul Lee <jongyoul@...>
Date: 2018-12-16T16:12:11Z
Remove `ZeppelinServer.notebook` and `ZeppelinServer.notebookWsServer`
commit ba0ed5d2a1a97bf39a89ff4eac6f38a297730224
Author: Jongyoul Lee <jongyoul@...>
Date: 2018-12-17T02:09:54Z
Remove `ZeppelinServer.notebook` and `ZeppelinServer.notebookWsServer`
commit 40193b8222d574b810ee19ba156a13ab05d66d7c
Author: Jongyoul Lee <jongyoul@...>
Date: 2018-12-17T05:34:11Z
Fix `HeliumBundleFactoryTest`
----
---
