Reamer commented on PR #4596:
URL: https://github.com/apache/zeppelin/pull/4596#issuecomment-1539470274

   We should definitely go for the Maven plugin.
   Everything else makes maintainability more difficult.
   
   The Maven plugin doesn't look that complicated.
   
   Change required in the parent `pom.xml`.
   ```
   <project>
     ...
      <properties>
          ...
          <antlr4.maven.version>4.3</antrl4.maven.version>
          ...
      </properties>
   ...
       <build>
      ....
       <pluginManagement>
         <plugins>
           <plugin>
             <groupId>org.antlr</groupId>
             <artifactId>antlr4-maven-plugin</artifactId>
             <version>${antlr4.maven.version}</version>
           </plugin>
         ....
   ```
   
   Inside the zeppelin-interpreter `pom.xml`
   ```
   <project>
     ...
     <build>
      ....
       <plugins>
         <plugin>
           <groupId>org.antlr</groupId>
           <artifactId>antlr4-maven-plugin</artifactId>
         </plugin>
         ...
       </plugins>
     </build>
     ...
   </project>
   ```
   
   Binds by default to the [lifecycle 
phase](http://maven.apache.org/ref/current/maven-core/lifecycles.html): 
generate-sources
   
   All you need are grammar files inside `src/main/antlr4` and a "link" 
implementation of zeppelin-interpreter to the generated source code.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to