Reamer commented on code in PR #4624:
URL: https://github.com/apache/zeppelin/pull/4624#discussion_r1244808864
##########
zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NoteManager.java:
##########
@@ -376,7 +381,7 @@ private NoteNode getNoteNode(String notePath) throws
IOException {
return noteNode;
}
- private Folder getFolder(String folderPath) throws IOException {
+ public Folder getFolder(String folderPath) throws IOException {
Review Comment:
I don't think it's a good idea to give the folder object to the outside. Do
you see a way to do the permissions check in the NoteManager class?
Currently there are already some checks in the NoteManager class.
https://github.com/apache/zeppelin/blob/55a614ad16d220842324f425a159cf41612d76f6/zeppelin-zengine/src/main/java/org/apache/zeppelin/notebook/NoteManager.java#L230-L232
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@zeppelin.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
