Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/12#issuecomment-87870293
Thanks for the contribution.
Here's some feedbacks,
a. Could you take care of indentation of pom.xml?
b. Version of hive-jdbc, hadoop-common dependency are hardcoded. Can we
make them configurable?
Note that spark interpreter module already uses hive.version and
hadoop.version maven property for his dependency. Hive interpreter module might
need new variable name.
c. Can we have some unittest?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
