[ 
https://issues.apache.org/jira/browse/ZEPPELIN-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14387559#comment-14387559
 ] 

ASF GitHub Bot commented on ZEPPELIN-11:
----------------------------------------

Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/12#issuecomment-87870293
  
    Thanks for the contribution.
    
    Here's some feedbacks,
    
    a. Could you take care of indentation of pom.xml?
    b. Version of hive-jdbc, hadoop-common dependency are hardcoded. Can we 
make them configurable?
        Note that spark interpreter module already uses hive.version and 
hadoop.version maven property for his dependency. Hive interpreter module might 
need new variable name.
    c. Can we have some unittest?
    



> Add a HiveQL interpreter to zeppelin
> ------------------------------------
>
>                 Key: ZEPPELIN-11
>                 URL: https://issues.apache.org/jira/browse/ZEPPELIN-11
>             Project: Zeppelin
>          Issue Type: New Feature
>            Reporter: Ram Venkatesh
>
> Add support for Hive and HiveQL to the zeppelin framework.
> Users can use the %hive directive to submit HiveQL statements.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to