[
https://issues.apache.org/jira/browse/ZEPPELIN-13?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14392708#comment-14392708
]
ASF GitHub Bot commented on ZEPPELIN-13:
----------------------------------------
Github user anthonycorbacho commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/20#issuecomment-88905833
This part
* [Shell
style](https://google-styleguide.googlecode.com/svn/trunk/shell.xml)
i.e:
```
if [ "$1" == "--config" ]
then
...
sould be
if [[ "$1" == "--config" ]]; then
...
```
> ZEPPELIN_CONF_DIR cannot be reached until ZEPPELIN_CONF_DIR become set
> ----------------------------------------------------------------------
>
> Key: ZEPPELIN-13
> URL: https://issues.apache.org/jira/browse/ZEPPELIN-13
> Project: Zeppelin
> Issue Type: Bug
> Components: Core
> Reporter: Jongyoul Lee
> Assignee: Jongyoul Lee
> Fix For: 0.5.0
>
>
> bin/common.sh tries to find and set ZEPPELIN_CONF_DIR in order to read
> zeppelin-env.sh, but ZEPPELIN_CONF_DIR is defined in zeppelin-env.sh, so we
> cannot use different ZEPPELIN_CONF_DIR.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
