Github user ZhijieWang commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/89#issuecomment-108378381
@corneadoug Thank you for your review.
Test
>Works for table data to CSV
>Kinda works for non-csv type of data, but the file is still .csv and while
my test didn't make the stack/text separated like a CSV, it could easily
happen.
There is tooltip on the button
I implemented intended for csv download. I believe if the user want to
download any plain text output, they can simple copy and paste.
>Cross-browser
I think we should establish a baseline -- allow user to be able to download
via right click "save as" or directly launch a download prompt. With some many
browsers out there, it is hard to make every feature work. Zeppelin project
should have "recommended" or "supported browsers". And unfortunately I don't
have IE anymore, so I can't test for that.
>Position of the button? (I actually like it there)
Feel free to move it around, i set it to show up when paragraph status ==
"FINISHED"
>Should the download data works only for table type of data?
I implemented intended for csv download. I believe if the user want to
download any plain text output, they can simple copy and paste. Maybe when data
is not in table format, the button should download the msg value and let end
user to do the transformation.
>Should the CSV be quoted? Should we use a library for the transformation?
I think we should, I only had numeric value at the time of implementation.
If the values are string with white space, it could cause problem.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
