So my question goes back to the mail list, what is the process in which I get feedback about my pull request? Is it going to be merged? Eran
---------- Forwarded message --------- From: DuyHai Doan <[email protected]> Date: יום ה׳, 30 ביולי 2015, 14:25 Subject: Re: [incubator-zeppelin] Improve magic display system (#164) To: IT CTO <[email protected]> Cc: DOAN DuyHai (JIRA) <[email protected]> Hello Eran I think that the decision of which pull request is ready/good enough to be merged into the trunk is decided by Apache Zeppelin PMC members. On Thu, Jul 30, 2015 at 12:38 PM, IT CTO <[email protected]> wrote: > Hi, > Since this is my first code contribution I was wondering what is the > process to get this merged to the master branch? > Can you help me? > Eran > > ---------- Forwarded message --------- > From: IT CTO <[email protected]> > Date: יום ג׳, 28 ביולי 2015, 07:10 > Subject: Re: [incubator-zeppelin] Improve magic display system (#164) > To: apache/incubator-zeppelin < > reply+0021fb8bd16161b97ac21af82b146da1313b30db2fb726d692cf0000000111cbaadd92a170ce021d7...@reply.github.com>, > apache/incubator-zeppelin <[email protected]> > > > Can someone look at this one and merge it if possible? > Eran > > בתאריך שבת, 25 ביולי 2015, 22:51 מאת Felix Cheung < > [email protected]>: > >> In >> zeppelin-interpreter/src/main/java/org/apache/zeppelin/interpreter/InterpreterResult.java >> <https://github.com/apache/incubator-zeppelin/pull/164#discussion_r35486267> >> : >> >> > - if (msg.startsWith(magic + " ") || msg.startsWith(magic + "\n")) { >> > - int magicLength = magic.length() + 1; >> > - if (msg.length() > magicLength) { >> > - return msg.substring(magicLength); >> > - } else { >> > - return ""; >> > - } >> > - } >> > + Type[] types = type.values(); >> > + TreeMap<Integer, Type> typesLastIndexInMsg = buildIndexMap(msg); >> > + if (typesLastIndexInMsg.size() == 0) { >> > + return msg; >> > + } else { >> > + Map.Entry<Integer, Type> lastType = typesLastIndexInMsg.lastEntry(); >> > + int magicLength = lastType.getValue().name().length() + 1; //add 1 >> > for the % >> > + int subStringPos = magicLength + lastType.getKey() + 1; // 1 for >> > the last \w after magic >> >> Cool!! >> >> — >> Reply to this email directly or view it on GitHub >> <https://github.com/apache/incubator-zeppelin/pull/164/files#r35486267>. >> >
