Hi, Here is Fixed PR [1] for Grunt Test. Now it work with master code.
[1] https://github.com/apache/incubator-zeppelin/pull/179 On Thu, Jul 9, 2015 at 1:27 PM, madhuka udantha <[email protected]> wrote: > Here is Fixed for test, > > https://github.com/apache/incubator-zeppelin/pull/147 > > On Thu, Jul 9, 2015 at 10:37 AM, madhuka udantha <[email protected] > > wrote: > >> I thought of clean it, (where it can be even run). So zeppelin developer >> can add their test. >> It is important to have test. >> What do you think? >> >> As I am needing it for my task even. >> Ideas are welcome >> >> On Thu, Jul 9, 2015 at 7:31 AM, Corneau Damien <[email protected]> >> wrote: >> >>> Its old tests related to an old implementation of zeppelin. >>> This is not relevant anymore, also we are never running them. >>> >>> >>> On Thu, Jul 9, 2015 at 12:20 AM, madhuka udantha < >>> [email protected]> >>> wrote: >>> >>> > I just run the >>> > incubator-zeppelin/zeppelin-web $ *grunt test* >>> > >>> > There are only 5 tests are define and all of them are failing. >>> > >>> > *PhantomJS 1.9.8 (Linux 0.0.0) Controller: MainCtrl should attach a >>> list of >>> > awesomeThings to the scope FAILED* >>> > * Error: [$injector:modulerr] Failed to instantiate module >>> zeppelinWeb2App >>> > due to:* >>> > * Error: [$injector:nomod] Module 'zeppelinWeb2App' is not available! >>> You >>> > either misspelled the module name or forgot to load it. If registering >>> a >>> > module ensure that you specify the dependencies as the second >>> argument.* >>> > * http://errors.angularjs.org/1.3.8/$injector/nomod?p0=zeppelinWeb2App >>> > <http://errors.angularjs.org/1.3.8/$injector/nomod?p0=zeppelinWeb2App >>> >* >>> > *.............* >>> > *PhantomJS 1.9.8 (Linux 0.0.0): Executed 5 of 5 (5 FAILED) ERROR (0.057 >>> > secs / 0.016 secs)* >>> > >>> > *Few things that I noticed on the Test* >>> > >>> > - Calling zeppelinWeb2App rather zeppelinWebApp >>> > - beforeEach(module('zeppelinWeb2App')); >>> > - This can be seen all the test, What is "zeppelinWeb2App"? >>> > - In Karma config files, are not correct and some are missing >>> > - This files will added correctly when you are following bower >>> install >>> > correctly. >>> > - Was there any reason for missing those? >>> > - Writing test are wrong >>> > - There is no any 'awesomeThings' to test in cotrl (this is >>> default >>> > Test) >>> > >>> > Your Ideas are welcome in here. >>> > [1] https://issues.apache.org/jira/browse/ZEPPELIN-161 >>> > <https://issues.apache.org/jira/browse/ZEPPELIN-161> >>> > -- >>> > Cheers, >>> > Madhuka Udantha >>> > http://madhukaudantha.blogspot.com >>> > >>> >> >> >> >> -- >> Cheers, >> Madhuka Udantha >> http://madhukaudantha.blogspot.com >> > > > > -- > Cheers, > Madhuka Udantha > http://madhukaudantha.blogspot.com > -- Cheers, Madhuka Udantha http://madhukaudantha.blogspot.com
