Renjith Kamath created ZEPPELIN-203:
---------------------------------------

             Summary: Cleanup jshint warnings
                 Key: ZEPPELIN-203
                 URL: https://issues.apache.org/jira/browse/ZEPPELIN-203
             Project: Zeppelin
          Issue Type: Improvement
          Components: build
            Reporter: Renjith Kamath


1) Fix the following jshint warnings and exclude Gruntfile.js
2) Remove --force from grunt build in pom.xml

{code}
Running "jshint:all" (jshint) task

Gruntfile.js
  line 258   col 0   Identifier 'screw_ie8' is not in camel case.
  line 262   col 0   Identifier 'screw_ie8' is not in camel case.
  line 264   col 0   Identifier 'dead_code' is not in camel case.
  line 268   col 0   Identifier 'if_return' is not in camel case.
  line 269   col 0   Identifier 'join_vars' is not in camel case.
  line 270   col 0   Identifier 'drop_console' is not in camel case.

src/app/app.controller.js
  line 34    col 66  Expected '!==' and instead saw '!='.

src/app/notebook/notebook.controller.js
  line 368   col 18  'i' is already defined.
  line 369   col 21  'setting' is already defined.
  line 345   col 42  'jQuery' is not defined.
  line 484   col 7   'isFunction' is defined but never used.

src/app/notebook/paragraph/paragraph.controller.js
  line 448   col 23  'pos' is already defined.
  line 876   col 21  'xLabels' is already defined.
  line 1259  col 16  'values' is already defined.
  line 1322  col 21  'colName' is already defined.
  line 1327  col 25  'withoutAggr' is already defined.
  line 1334  col 21  'colName' is already defined.
  line 1335  col 25  'withoutAggr' is already defined.
  line 1344  col 23  'colName' is already defined.
  line 62    col 86  'hljs' is not defined.

✖ 20 problems

Warning: Task "jshint:all" failed. Used --force, continuing.
{code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to