Github user cdfhuang commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/184#issuecomment-129218142
Yup, we should, and the default provider chain takes care of that. The
[documentation](http://docs.aws.amazon.com/AWSJavaSDK/latest/javadoc/com/amazonaws/auth/DefaultAWSCredentialsProviderChain.html)
for the default provider chain mentions that it'll look at four different
places in a pre-defined order for credentials. The first place is the
environment variables. It will then fall back to Java properties, credentials
files (~/.aws/credentials), and lastly instance profiles. So nothing is lost
from the original way of authentication for S3 notebooks.
One note is that the documentation mentions AWS_SECRET_KEY, but this
[thread](https://github.com/aws/aws-cli/issues/97) mentions a standardization
for AWS_SECRET_ACCESS_KEY. I've tested this PR to work with my set of
AWS_SECRET_KEY and AWS_SECRET_ACCESS_KEY as well.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
