Github user Leemoonsoo commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/167#issuecomment-129591182
@randerzander what do you think about feedback from @tzolov ?
> * You may want to define a maxResultRow to restrict the max number of
result displayed or you risk to kill your zeppelin. In couple of occasions I've
forgotten to set sql LIMIT and managed to freeze the front end.
> * As a safeguard you can call the close() in your open method before
opening the connection
> * For testing use proper Mockito and MockRunner
PostgreSqlInterpreterTest.java
@tzolov generalizing Dependency implementation is definitely a direction
(along with generalizing ZeppelinContext). We can think two different level of
generalize.
1) generalize dependency downloading
Generalize package
[org.apache.zeppelin.spark.dep](https://github.com/apache/incubator-zeppelin/tree/master/spark/src/main/java/org/apache/zeppelin/spark/dep)
2) generalize dependency interpreter
Generalize package
[org.apache.zeppelin.spark.dep](https://github.com/apache/incubator-zeppelin/tree/master/spark/src/main/java/org/apache/zeppelin/spark/dep)
and
[DepInterpreter](https://github.com/apache/incubator-zeppelin/blob/master/spark/src/main/java/org/apache/zeppelin/spark/DepInterpreter.java)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
