Prabhjyot Singh created ZEPPELIN-235:
----------------------------------------
Summary: jscs in zeppelin-web
Key: ZEPPELIN-235
URL: https://issues.apache.org/jira/browse/ZEPPELIN-235
Project: Zeppelin
Issue Type: Improvement
Components: build
Reporter: Prabhjyot Singh
Assignee: Prabhjyot Singh
details from email thread.
Basic config to start with, add other necessary flags
https://gist.github.com/r-kamath/fad6aaf77c3fcde4555d
{quote}
---------- Forwarded message ----------
From: Renjith Kamath <renjith.kam...@gmail.com>
Date: 18 August 2015 at 00:34
Subject: Re: jscs in zeppelin-web
To: dev <dev@zeppelin.incubator.apache.org>
with this updated config I see about 671 errors
https://gist.github.com/r-kamath/fad6aaf77c3fcde4555d
Thanks & Regards,
RK
On Tue, Aug 18, 2015 at 12:06 AM, Renjith Kamath <renjith.kam...@gmail.com>
wrote:
> Thanks Corneau.
> Older versions of jsHint used to have settings like onevar and trailing,
> now they are deprecated. and
> jscs looks only at code formatting issues (trailing space, extra comma,
> usage of multiple var. etc.)
> Currently in zeppelin there are about 513 code style errors. Please see
> the attachment for my local jscs output
>
> Thanks & Regards,
> RK
>
> On Mon, Aug 17, 2015 at 9:41 PM, Corneau Damien <cornead...@gmail.com>
> wrote:
>
>> I will take a look at jscs, what is that different from jshint? seems like
>> they got a lot of settings in common.
>> Maybe you could list some code style problems you saw, that are not
>> currently picked up by jshint.
>> For jshint unused variables, I think it should be activated to some degree
>> right now.
>>
>> On Tue, Aug 18, 2015 at 12:26 AM, Renjith Kamath <
>> renjith.kam...@gmail.com>
>> wrote:
>>
>> > Hi Team,
>> >
>> > Can we add jscs in zeppelin-web to enforce code style, currently we do
>> not
>> > have any checks in place for js code style, similarly restrict unused
>> > variables and max line length using jshint.
>> >
>> > Please let me know your thoughts and comments on this. Thanks!
>> >
>> >
>> > Thanks & Regards,
>> > RK
>> >
>>
>
>
{quote}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
