Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/244#issuecomment-133769881
  
    Here's summary of changes made by this patch.
    
    ##### Add spark-dependencies submodule
    
    spark-dependencies maven submodule is created. It is responsible for copy 
all the spark/hadoop dependencies under interpreter/spark/dep.
    
    Spark/Hadoop dependencies in spark maven submodule is set to provided, 
while they're loaded on runtime from either interpreter/spark/dep or 
SPARK_HOME,HADOOP_HOME.
    
    ##### bin/interpreter.sh
    
    bin/interpreter.sh checks if SPARK_HOME and HADOOP_HOME is defined.
    If they're not defined, it adds interpreter/spark/dep into classpath.
    If they're defined, it does add directories from SPARK_HOME and HADOOP_HOME 
into classpath. 
    
    It also searches for spark-*.conf file under SPARK_HOME/conf and 
automatically add them into ZEPPELIN_JAVA_OPTS.
    
    ##### remove use of travis-install.sh from .travis
    
    While travis-install.sh reduces logs, it brings some problem.
    When build is hanging for some reason, before travis-install.sh gets error 
and printing them, travis terminates the build container. It makes very hard to 
debug.
    
    This is ready to review.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to