Github user corneadoug commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/229#issuecomment-133779847
We might have to work on the configuration for indentation.
### Example:
#### current formatting in this branch
```
angular.module('zeppelinWebApp').controller('ParagraphCtrl',
function($scope, $rootScope, $route, $window, $element, $routeParams,
$location, $timeout, $compile,
websocketMsgSrv) {
```
Gives a 4 spaces prefix indent for the function code
#### One line formatting
```
angular.module('zeppelinWebApp').controller('ParagraphCtrl',
function($scope, $rootScope, $route, $window, $element, $routeParams,
$location, $timeout, $compile, websocketMsgSrv) {
```
Gives a 2 spaces prefix indent for the function code but obviously more
than 120 characters line.
#### Super line formatting
```
angular
.module('zeppelinWebApp')
.controller('ParagraphCtrl',
function($scope, $rootScope, $route, $window, $element,
$routeParams, $location, $timeout, $compile,
websocketMsgSrv) {
```
or
```
angular
.module('zeppelinWebApp')
.controller('ParagraphCtrl',
function($scope,
$rootScope,
$route,
$window,
$element,
$routeParams,
$location,
$timeout,
$compile,
websocketMsgSrv) {
```
Then I have jscs errors asking for a 16 spaces prefix indent for the
function code.
In the end, I'm not sure which indenting is the best.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
