Github user Leemoonsoo commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/264#issuecomment-136437760
  
    @felixcheung 
    
    > Is this a bug:
    > ```
    if (!key.startsWith("spark.") || !val.trim().isEmpty()) {
            logger.debug(String.format("SparkConf: key = [%s], value = [%s]", 
key, val));
            conf.set(key, val);
          }
    ```
    > Shouldn't it say `if (key.startsWith("spark.")`?
    
    I think it's not a bug. Designed to not pass empty value when the key 
starts with "spark."
    This unittest might helpful to understand.
    
https://github.com/apache/incubator-zeppelin/blob/master/spark/src/test/java/org/apache/zeppelin/spark/SparkInterpreterTest.java#L168


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to