I agree with corneadoug, if we automatically persist the properties when user press save without pressing the + sigh then we have to add some kind of cancel only on the preperty level. say I just typed in a property name and value and did not press +, how do I cancel this without saving?
maybe a dirty flag can be added and a warning when we press save without saving the property value first? Eran On Wed, Sep 16, 2015 at 10:33 AM corneadoug <g...@git.apache.org> wrote: > Github user corneadoug commented on the pull request: > > > https://github.com/apache/incubator-zeppelin/pull/308#issuecomment-140655687 > > I think that behavior (not saving what is in the form) is okay. > However, properties that were added should not be shown with an input, > otherwise it's confusing. >  > > > > --- > If your project is set up for it, you can reply to this email and have your > reply appear on GitHub as well. If your project does not have this feature > enabled and wishes so, or if the feature is enabled but not working, please > contact infrastructure at infrastruct...@apache.org or file a JIRA ticket > with INFRA. > --- > -- Eran | "You don't need eyes to see, you need vision" (Faithless)
