GitHub user RPCMoritz opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/315
#315 Fix time-dependant scheduling test
test-schedule can fail when it starts late in a second, as the result will
then return the next second due to in-system delays (particularly cron not
reacting in time to config.put(cron, null)).
Adding an additional waiting second before measuring dateFinished allows us
to take a value that is independent of a possible lagging execution, waiting
another second makes sure that the process has properly stopped.
Alternatively, we can test the time and make sure to not write to cron when
just before the full second - that would be quicker (less waiting) but slightly
more hacky.
Please review.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/RPCMoritz/incubator-zeppelin patch-1
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/315.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #315
----
commit 6215563857c21d7ef2878565e9e8b459196b7004
Author: Rick Moritz <[email protected]>
Date: 2015-09-21T17:10:37Z
Fix time-dependant scheduling test
test-schedule can fail when it starts late in a second, as the result will
then return the next second due to in-system delays (particularly cron not
reacting in time to config.put(cron, null)).
Adding an additional waiting second before measuring dateFinished allows us
to take a value that is independent of a possible lagging execution, waiting
another second makes sure that the process has properly stopped.
Alternatively, we can test the time and make sure to not write to cron when
just before the full second - that would be quicker (less waiting) but slightly
more hacky.
Please review.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
