Github user datagiraffe commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/238#issuecomment-144072730
  
    Map Visualization for Zeppelin would be a great addition!
    I've tried the code and ran into several problems.
    
    I don't think it's good to select the lat and lon statically like so:
    
https://github.com/Madhuka/incubator-zeppelin/blob/milestone05-map/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js#L866
    It would be nice if they were detected automatically. Maybe if there are 
columns lat, latitude, lon, long or longitude, pick them?
    
    The same goes for the key:
    
https://github.com/Madhuka/incubator-zeppelin/blob/milestone05-map/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js#L863
    If a key exists twice, it obviously breaks. Key and message are the same 
though, but I may be interested in the same message at different locations.
    
    There should be a settings drop down like for the other chart types where 
this can be configured. With the current version, that doesn't seem to work. 
(Only for me?)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to