Github user elbamos commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/523#issuecomment-163145070
This is a really good template.
Two questions:
1. Do other open source projects find this level of formality necessary?
I'm not saying its a bad idea. I just think whenever we have an issue, the
first place we look should be to the experience of other projects.
2. Does it make sense to have a template for use *by the reviewer*? I've
seen a lot of "looks good to me" written so quickly after a PR is made, there's
no way the reviewer could have compiled it, let alone tested it. (I don't
think this actually is an issue on other projects.) So I'm wondering if it
would be a good idea to ask that reviews give some indication of the nature of
the review?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
