GitHub user cloverhearts opened a pull request:

    https://github.com/apache/incubator-zeppelin/pull/556

    table scrolling bug fixed. out of area scroll issue

    ### What is this PR for?
    Scrollbar position when you scroll through the table has been modified with 
parts that are expressed differently in the length of the actual data.
    
    ### What type of PR is it?
    Bug Fix
    
    ### Todos
    - [x] Perfect Scroll-based Zeppelin scroll bug fix
    - [x] Browser Test
      - [x] Safari (9.0.2(11601.3.9)
      - [x] Firefox (43.0)
      - [x] Chrome (47.0.2526.106 (64-bit)
    
    ### Is there a relevant Jira issue?
    https://issues.apache.org/jira/browse/ZEPPELIN-523
    ### How should this be tested?
    Step 1. create table on zeppelin
               example query) 
    ``` python
    %pyspark
    TABLE = "%table Header1\tHeader2\n"
    for x in range(1,51):
        #TABLE +=  "scroll";
        TABLE +=  str(x);
        if (x%2) == 0:
            TABLE += "\n"
        else:
            TABLE += "\t"
    z.put("table_context", TABLE)
    
    ```
    ``` scala
    println(z.get("table_context"))
    ```
    
    Step 2. 
    Scroll the mouse over the Table.
    ### Screenshots (if appropriate)
    
    #### Before
    
![before](https://cloud.githubusercontent.com/assets/10525473/11911933/4cf27744-a5dc-11e5-8f45-e1e15e532de9.gif)
    
    #### After
    
![after](https://cloud.githubusercontent.com/assets/10525473/11912019/23a3d6dc-a5df-11e5-928a-c8b46fca7512.gif)
    
    
    ### Questions:
    Why did this problem occur?
    - ref. https://github.com/noraesae/perfect-scrollbar#how-to-use perfect 
scrollbar library. 
      height calculation miss.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/cloverhearts/incubator-zeppelin 
bug_fix/table_scrolling

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-zeppelin/pull/556.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #556
    
----
commit a0db646f1e0f12ef5f07c0db711f1d88e9f1fece
Author: CloverHearts <estai...@gmail.com>
Date:   2015-12-19T06:16:04Z

    table scrolling bug fixed. out of area scroll issue

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to