GitHub user cloverhearts opened a pull request:
https://github.com/apache/incubator-zeppelin/pull/565
Bug fix/table scrolling and hiding
### What is this PR for?
For Table, reimplemented, scrolling, deleting a bug in the Table Header,
Scrolling area expressed bugs have been fixed.
### What type of PR is it?
Bug Fix
### Todos
- [x] \(Re-modification\) always top fixed column title for table
- [x] table scrolling bug fixed. out of area scroll
https://github.com/apache/incubator-zeppelin/pull/556
- [x] After the re-run, remove the scroll bar
- [x] License Infomation
- [x] record the license information of jquery.floatThead.
- [x] Browser Test
- [x] Safari (9.0.2(11601.3.9)
- [x] Firefox (43.0)
- [x] Chrome (47.0.2526.106 (64-bit)
### Is there a relevant Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-523
### How should this be tested?
Step 1. create table on zeppelin
example query)
``` python
%pyspark
TABLE = "%table Header1\tHeader2\n"
for x in range(1,51):
#TABLE += "scroll";
TABLE += str(x);
if (x%2) == 0:
TABLE += "\n"
else:
TABLE += "\t"
z.put("table_context", TABLE)
```
``` scala
println(z.get("table_context"))
```
Step 2.
Scroll the mouse over the Table.
Step 3.
re Run Paragraph.
Step 4.
Scroll the mouse over the Table.
### Screenshots (if appropriate)
#### Before
#### After
### Questions:
You are using an external source?
\- I used jquery.floatThead (MIT) Libraries.
It helps to secure the Table Header.
Why did this problem occur?
\- ref. https://github.com/noraesae/perfect-scrollbar#how-to-use perfect
scrollbar library.
height calculation miss.
Why it has created a new PR?
\- A problem with a private Git Repository to my mistakes.
Please previous PR, see the following URL.
https://github.com/apache/incubator-zeppelin/pull/556
In the ScreenShot, it seems to have changed color table. What changed
things?
\- no. It's Animated Gif color problems.
Changes that do not exist.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloverhearts/incubator-zeppelin
bug_fix/table_scrolling_and_hiding
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-zeppelin/pull/565.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #565
----
commit bf16e1aa108dd565b41c372d24ddd8ee1ab3a128
Author: CloverHearts <[email protected]>
Date: 2015-12-22T08:45:40Z
bug fixed visualize table component
commit f8123c54b16db63857764f83eed57e7c44caeb5a
Author: CloverHearts <[email protected]>
Date: 2015-12-22T09:01:02Z
Fixed scrollbar when the first Mouseover does not appear in the Table.
commit ba165bf42ec493c12863c057523acf2d02c69c67
Author: CloverHearts <[email protected]>
Date: 2015-12-22T09:08:56Z
variable name change
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
