Github user HeartSaVioR commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/574#issuecomment-167471224
Great for reducing complexity, modified code looks good to me.
Btw, CI test is failing,
```
Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 6.548 sec
<<< FAILURE! - in org.apache.zeppelin.rest.ZeppelinSparkClusterTest
org.apache.zeppelin.rest.ZeppelinSparkClusterTest Time elapsed: 6.547 sec
<<< ERROR!
java.lang.NullPointerException: null
at
org.apache.zeppelin.rest.AbstractTestRestApi.startUp(AbstractTestRestApi.java:127)
at
org.apache.zeppelin.rest.ZeppelinSparkClusterTest.init(ZeppelinSparkClusterTest.java:48)
```
Related code block is here,
```
// assume first one is spark
InterpreterSetting sparkIntpSetting = null;
for(InterpreterSetting intpSetting :
ZeppelinServer.notebook.getInterpreterFactory().get()) {
if (intpSetting.getGroup().equals("spark")) {
sparkIntpSetting = intpSetting;
}
}
```
Does this occur first time? Maybe we can't rely on sequence of interpreter
setting now?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
