Github user hayssams commented on the pull request:
https://github.com/apache/incubator-zeppelin/pull/53#issuecomment-168234161
You are right that should be removed.
I took it from the shiro sample.
I am removing the whole section right away.
Cordialement.
Hayssam Saleh, CTO
+33 6 85 71 13 95 <> | LinkedIn Profile
<http://fr.linkedin.com/pub/hayssam-saleh/0/144/bb8> | ebiznext :)
<http://www.ebiznext.com/> | Skype ID <http://hayssam.saleh2/>
> On 31 Dec 2015, at 20:27, Jeff Steinmetz <notificati...@github.com> wrote:
>
> One comment: why is Stormpath (a commercial auth service unrelated to
Zeppelin) mentioned in the comments for this PR?
> See:
>
https://github.com/apache/incubator-zeppelin/pull/586/files#diff-9b7b90bbe0069ba81385d11637dcd4e4R27
>
>
> From: Hayssam Saleh
> Reply-To: apache/incubator-zeppelin
> Date: Thursday, December 31, 2015 at 10:06 AM
> To: apache/incubator-zeppelin
> Cc: Jeff Steinmetz
> Subject: Re: [incubator-zeppelin] Added Shiro security (#53)
>
>
> @elbamos @jongyoul @rconline
> I created a new PR (#586) which implements HTTP et Websocket security but
does not implement note ownership. This means that a user must authenticate to
access Zeppelin but once authenticated, he will have access to all notes.
That's what @Leemoonsoo wanted to do first.
>
> For easier review, this new PR (#586) contains only two commits. The
first one implements HTTP Auth and the second one Websocket authentication .
>
> Once PR # 586 is merged / validated, I suggest that we move forward with
note ownership and permissions.
>
> â
> Reply to this email directly or view it on GitHub.
>
>
>
> â
> Reply to this email directly or view it on GitHub
<https://github.com/apache/incubator-zeppelin/pull/53#issuecomment-168232632>.
>
--
*EBIZNEXT <http://www.ebiznext.com> Java / .NET **/ DevOps / BigData / UX
/ Agile*
23 rue Vernet 75008 Paris
<https://maps.google.com/?q=23%20rue%20Vernet%2075008%20Paris>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
