Github user corneadoug commented on the pull request:

    https://github.com/apache/incubator-zeppelin/pull/578#issuecomment-170763676
  
    While reviewing this PR, I found out that the 
**docs/development/writingzeppelininterpreter.md** might not be accurate.
    
    For example, in 
https://github.com/apache/incubator-zeppelin/blob/master/docs/development/writingzeppelininterpreter.md#configure-your-interpreter
    
    The interpreter should be added to `conf/zeppelin-site.xml.template` only 
(since conf/zeppelin-site.xml is user configuration)
    
    And the part about default configuration should not be as a 'Note' but as a 
step to do.
    
    In the end, it should look like this:
    
    
    ### Configure your interpreter
    
    To configure your interpreter you need to follow these steps:
    
    1. Add your interpreter class name to the zeppelin.interpreters property in 
`conf/zeppelin-site.xml.template`
    
      Property value is comma separated [INTERPRETER_CLASS_NAME].
    
      For example:
      
      ```
    <property>
      <name>zeppelin.interpreters</name>
      
<value>org.apache.zeppelin.spark.SparkInterpreter,org.apache.zeppelin.spark.PySparkInterpreter,org.apache.zeppelin.spark.SparkSqlInterpreter,org.apache.zeppelin.spark.DepInterpreter,org.apache.zeppelin.markdown.Markdown,org.apache.zeppelin.shell.ShellInterpreter,org.apache.zeppelin.hive.HiveInterpreter,com.me.MyNewInterpreter</value>
    </property>
    ```
    
    2. Add your interpreter to the [default 
configuration](https://github.com/apache/incubator-zeppelin/blob/master/zeppelin-zengine/src/main/java/org/apache/zeppelin/conf/ZeppelinConfiguration.java#L397)
 which is used when there is no `zeppelin-site.xml`.
    
    3. Start zeppelin by running ```./bin/zeppelin-deamon start```
    
    4. In the interpreter page, click the `+Create` button and configure your 
interpreter properties.
    Now you are done and ready to use your interpreter.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to