Hi, I didn't know about history of adding 'scalding' module, and I see it is excluded from default by intention. https://github.com/apache/incubator-zeppelin/pull/561
So it's fine that binary distribution doesn't include scalding. For source code distribution, if we don't use 'scalding' profile when releasing with maven release plugin, version information of scalding/pom.xml will not be changed. https://github.com/apache/incubator-zeppelin/commit/8698d0e5d376800b174d8b604f584b86b3037d65 (Geode, too) It would be contradiction that we should get rid of scalding / geode from binary distribution (so we don't want to set profiles) but maven release plugin should change version information to two modules' pom.xml (it requires setting profiles). So I'm now +1 (non-binding) for RC2 but it would be better to document since users should fix pom.xml of scalding and geode by hand to build module from specific version (or version branch) of source code. Thanks, Jungtaek Lim (HeartSaVioR) On Fri, Jan 15, 2016 at 3:04 PM, Felix Cheung <[email protected]> wrote: > Hi Jungtaek, > I was able to reproduce the issues you have reported, > Source1. One Ignite test failedTests run: 2, Failures: 1, Errors: 0, > Skipped: 0, Time elapsed: 1.841 sec <<< FAILURE! - in > org.apache.zeppelin.ignite.IgniteSqlInterpreterTesttestSql(org.apache.zeppelin.ignite.IgniteSqlInterpreterTest) > Time elapsed: 0.913 sec <<< FAILURE!java.lang.AssertionError: > expected:<SUCCESS> but was:<ERROR>at > org.junit.Assert.fail(Assert.java:88)at > org.junit.Assert.failNotEquals(Assert.java:743)at > org.junit.Assert.assertEquals(Assert.java:118)at > org.junit.Assert.assertEquals(Assert.java:144)at > org.apache.zeppelin.ignite.IgniteSqlInterpreterTest.testSql(IgniteSqlInterpreterTest.java:96)Results > :Failed tests: IgniteSqlInterpreterTest.testSql:96 expected:<SUCCESS> but > was:<ERROR> > 2. Scalding interpreter build failed – I believe this has been reported > with fix in a pending PR:[ERROR] Failed to execute goal on project > zeppelin-scalding: Could not resolve dependencies for project > org.apache.zeppelin:zeppelin-scalding:jar:0.6.0-incubating-SNAPSHOT: Could > not find artifact > org.apache.zeppelin:zeppelin-interpreter:jar:0.6.0-incubating-SNAPSHOT in > conjars ( http://conjars.org/repo) > Binary1. Scalding interpreter is not included in the distribution > > > _____________________________ > From: Jungtaek Lim <[email protected]> > Sent: Thursday, January 14, 2016 5:43 AM > Subject: Re: [VOTE] Release Apache Zeppelin (incubating) 0.5.6-incubating > (RC2) > To: <[email protected]> > > > Hi, > > I found some issues from RC2, > > A. building from source (zeppelin-0.5.6-incubating.tgz) > > Test with executing "mvn clean package -Pspark-1.6 -Phadoop-2.4 -Pyarn > -Ppyspark -Dignite.version=1.1.0-incubating -Pscalding" > > 1. 'scalding' module refers wrong zeppelin version as > 0.6.0-incubating-snapshot which breaks the build with option -Pscalding. > 2. 'ignite' module: Test failure occurs on my Mac. I don't know about > ignite, so is there any precondition to enable 'ignite' interpreter? > > IgniteSqlInterpreterTest.testSql:95 expected:<SUCCESS> but was:<ERROR> > > B. using binary version (zeppelin-0.5.6-incubating-bin-all.tgz) > > 1. Seems like scalding interpreter is not on list. > > Unfortunately -0 (non-binding) on this (I can't sure these are blockers so > I don't vote -1, leaving it to PMCs) > > Best, > Jungtaek Lim (HeartSaVioR) > > > On Thu, Jan 14, 2016 at 2:53 PM, Corneau Damien <[email protected]> > wrote: > > > +1 (binding) > > > > On Thu, Jan 14, 2016 at 2:38 PM, moon soo Lee <[email protected]> wrote: > > > > > +1 (binding) > > > > > > On Tue, Jan 12, 2016 at 9:09 PM Felix Cheung < > [email protected]> > > > wrote: > > > > > > > +1 > > > > > > > > Tested: > > > > packaged spark, external sparkSpark/Scala, pyspark, md, sh, flink, > > > various > > > > UI features > > > > Found and filed these bugs, I don't think they are blockers: > > > > > > > > https://issues.apache.org/jira/browse/ZEPPELIN-599 notebook > search > > > > should search paragraph titlehttps:// > > > > issues.apache.org/jira/browse/ZEPPELIN-600 notebook search should > > have > > > a > > > > way to clear search and return to the previous pagehttps:// > > > > issues.apache.org/jira/browse/ZEPPELIN-601 import new note, add > from > > > url > > > > textbox is not clearing buttons from previous choiceshttps:// > > > > issues.apache.org/jira/browse/ZEPPELIN-602 elasticsearch throws > > > > ArrayIndexOutOfBoundsException for interpreting an empty paragraph > > > > > From: [email protected] > > > > > Date: Wed, 13 Jan 2016 13:58:19 +0900 > > > > > Subject: Re: [VOTE] Release Apache Zeppelin (incubating) > > > > 0.5.6-incubating (RC2) > > > > > To: [email protected] > > > > > > > > > > +1 (binding) > > > > > > > > > > On Tue, Jan 12, 2016 at 9:55 AM, Jongyoul Lee <[email protected] > > > > > > wrote: > > > > > > > > > > > +1 (binding), looks good to move forward to Spark 1.6 > > > > > > > > > > > > On Mon, Jan 11, 2016 at 11:27 PM, Alexander Bezzubov < > > > > [email protected] > > > > > > > > > > > > > wrote: > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > I am pleased to be calling this vote for the following RC2 to > be > > > > release > > > > > > as > > > > > > > Apache Zeppelin incubating-0.5.6 > > > > > > > > > > > > > > Vote on RC1 got canceled, next issues were included in the RC2 > > > > > > > https://issues.apache.org/jira/browse/ZEPPELIN-564 > > > > > > > https://issues.apache.org/jira/browse/ZEPPELIN-565 > > > > > > > https://github.com/apache/incubator-zeppelin/pull/616 - > Fix > > > > > > > documentation > > > > > > > https://github.com/apache/incubator-zeppelin/pull/617 - > Fix > > > > website > > > > > > > https://github.com/apache/incubator-zeppelin/pull/618 - > Spark > > > 1.6 > > > > > > > for embedded > > > > > > > dependency in binary package > > > > > > > https://github.com/apache/incubator-zeppelin/pull/613 - > Fix + > > > (new > > > > > > > paragraph) > > > > > > > appearing in iframe link > > > > > > > https://github.com/apache/incubator-zeppelin/pull/605 - > > Pyspark > > > > does > > > > > > > not work > > > > > > > in yarn-client without spark.yarn.isPython set true > > > > > > > > > > > > > > > > > > > > > The release candidate consists of the following source > > distribution > > > > > > archive > > > > > > > zeppelin-0.5.6-incubating.tgz > > > > > > > > > > > > > > In addition, the following supplementary binary distributions > are > > > > > > provided > > > > > > > for > > > > > > > user convenience at the same location > > > > > > > zeppelin-0.5.6-incubating-bin-all.tgz > > > > > > > > > > > > > > The source zip, including signatures, digests, etc. can be > found > > > at: > > > > > > > * > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/zeppelin/0.5.6-incubating-rc2/ > > > > > > > < > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/zeppelin/0.5.6-incubating-rc2/ > > > > > > > >* > > > > > > > > > > > > > > The maven artifacts are here > > > > > > > * > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachezeppelin-1006 > > > > > > > < > > > > > > > > > > > > > > > > https://repository.apache.org/content/repositories/orgapachezeppelin-1006 > > > > > > > >* > > > > > > > > > > > > > > The Git tag is v0.5.6 > > > > > > > The Git commit ID is 8698d0e5d376800b174d8b604f584b86b3037d65 > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://git-wip-us.apache.org/repos/asf?p=incubator-zeppelin.git;a=commit;h=8698d0e5d376800b174d8b604f584b86b3037d65 > > > > > > > > > > > > > > Release artifacts are signed with the following key: > > > > > > > https://people.apache.org/keys/committer/bzz > > > > > > > > > > > > > > KEYS file available here: > > > > > > > > https://dist.apache.org/repos/dist/dev/incubator/zeppelin/KEYS > > > > > > > > > > > > > > 131 issues were closed/resolved for this release: > > > > > > > > > > > > https://issues.apache.org/jira/browse/ZEPPELIN/fixforversion/12334165/ > > > > > > > > > > > > > > Release note highlights can be found here: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12316221&version=12334165 > > > > > > > > > > > > > > The vote will be open for 72 hours. > > > > > > > Please download the release candidate and evaluate the > necessary > > > > items > > > > > > > including checking hashes, signatures, build from source, and > > test. > > > > > > > > > > > > > > The please vote: > > > > > > > [ ] +1 Release this package as Zeppelin 0.5.6-incubating > > > > > > > [ ] +0 no opinion > > > > > > > [ ] -1 Do not release this package because because... > > > > > > > > > > > > > > > > > > > > > -- > > > > > > > Kind regards, > > > > > > > Alexander. > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > > 이종열, Jongyoul Lee, 李宗烈 > > > > > > http://madeng.net > > > > > > > > > > > > > > > > > > > > > > > > > > -- > > > > > -- > > > > > Kind regards, > > > > > Alexander. > > > > > > > > > > > > > -- > Name : Jungtaek Lim > Blog : http://medium.com/@heartsavior > Twitter : http://twitter.com/heartsavior > LinkedIn : http://www.linkedin.com/in/heartsavior > > > > > -- Name : Jungtaek Lim Blog : http://medium.com/@heartsavior Twitter : http://twitter.com/heartsavior LinkedIn : http://www.linkedin.com/in/heartsavior
